launchtemplate docs #773
Merged
launchtemplate docs #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: ff0a33d 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61955e7d116729000830bd4a 😎 Browse the preview: https://deploy-preview-773--karpenter-docs-prod.netlify.app |
|
thanks for the thoughtful feedback @JacobGabrielson :) -Geoffrey |
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
geoffcline
commented
Oct 28, 2021
ellistarn
reviewed
Nov 1, 2021
ellistarn
reviewed
Nov 1, 2021
| @@ -0,0 +1,207 @@ | |||
| --- | |||
There was a problem hiding this comment.
We need to put this section under a parent AWS Provider section.
ellistarn
reviewed
Nov 1, 2021
ellistarn
reviewed
Nov 1, 2021
ellistarn
reviewed
Nov 1, 2021
|
new draft pushed and ready for review 🥳 |
ellistarn
reviewed
Nov 4, 2021
| @@ -1,13 +1,11 @@ | |||
| --- | |||
| title: "Amazon Web Services (AWS)" | |||
| linkTitle: "AWS" | |||
| title: "Specifying Values to Control AWS Provisioning" | |||
There was a problem hiding this comment.
I'd keep this simple and directly related to our concept of what this page is like "AWS Cloud Provider".
There was a problem hiding this comment.
If this page lives in the "AWS" navigation section / folder, I'd like to give it a more descriptive title, than just repeating AWS.
docs/AWS/AWS.html vs
docs/AWS/labels.html or constraints.html etc
ellistarn
reviewed
Nov 4, 2021
ellistarn
reviewed
Nov 4, 2021
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
bwagner5
reviewed
Nov 5, 2021
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
eptiger
reviewed
Nov 9, 2021
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
bwagner5
reviewed
Nov 15, 2021
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
|
|
||
| ### Instance Profile - IAM | ||
|
|
||
| The launch template must include an "instance profile" -- a set of IAM roles. |
There was a problem hiding this comment.
sorry this got dropped?
website/content/en/docs/cloud-providers/AWS/launch-templates.md
Outdated
Show resolved
Hide resolved
geoffcline
force-pushed
the
launch-template
branch
from
4cd9735 to
a8df3de
Compare
ellistarn
previously approved these changes
Nov 17, 2021
revise draft on lts revise lt docs wrap lines
Co-authored-by: Ellis Tarn <[email protected]>
Co-authored-by: Elton <[email protected]>
geoffcline
force-pushed
the
launch-template
branch
from
a8df3de to
ff0a33d
Compare
ellistarn
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
https://github.com/awslabs/karpenter/projects/4#card-65981773
2. Description of changes:
Add a new page describing launch templates, including requirements and sample procedure.
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.